Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(framework) Update Flower tutorial series to Flower Next (part 3 of 4) #3314

Merged
merged 20 commits into from
Jul 26, 2024
Merged

docs(framework) Update Flower tutorial series to Flower Next (part 3 of 4) #3314

merged 20 commits into from
Jul 26, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Apr 23, 2024 •
edited
Loading

Issue

Description

Part 3 of the Flower tutorial series uses the start_simulation() approach, which is pre-Flower 1.8.

Related issues/PRs

Related to #3295, #3313.

Proposal

Explanation

This PR updates Part 3 of the Flower tutorial series. Changes:

  • Replace start_simulation() with run_simulation().
  • Add the ClientApp and ServerApp objects, with accompanying descriptions.
  • Update client_fn signature to use with partition_id.

Checklist

  • Implement proposed change
  • [ ] Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass

Changelog entry

Any other comments?

@chongshenng chongshenng self-assigned this Apr 23, 2024
@chongshenng chongshenng added the documentation Improvements or additions to documentation label Apr 23, 2024
@chongshenng chongshenng mentioned this pull request Apr 23, 2024
Merged
4 tasks
@chongshenng chongshenng changed the title Update Flower tutorial series to Flower Next (part 3) Update Flower tutorial series to Flower Next (part 3 of 4) Apr 23, 2024
@chongshenng chongshenng marked this pull request as ready for review April 23, 2024 14:00
@chongshenng chongshenng marked this pull request as draft April 24, 2024 15:58
@chongshenng chongshenng marked this pull request as ready for review April 25, 2024 10:03
@chongshenng chongshenng changed the title Update Flower tutorial series to Flower Next (part 3 of 4) docs(framework) Update Flower tutorial series to Flower Next (part 3 of 4) May 28, 2024
@chongshenng chongshenng marked this pull request as draft July 12, 2024 11:34
@chongshenng chongshenng marked this pull request as ready for review July 26, 2024 10:40
@danieljanes danieljanes enabled auto-merge (squash) July 26, 2024 15:56
@danieljanes danieljanes merged commit 159d248 into main Jul 26, 2024
34 checks passed
@danieljanes danieljanes deleted the update-flwr-next-part-3-tutorial-series branch July 26, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danielnugraha danielnugraha Awaiting requested review from danielnugraha

Assignees

@chongshenng chongshenng

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongshenng @danieljanes