Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Implement run_supernode #3353

Merged
merged 21 commits into from
Jun 13, 2024
Merged

feat(framework) Implement run_supernode #3353

merged 21 commits into from
Jun 13, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Apr 29, 2024

  • Call get_run and pass fab_id & fab_version to load_client_app_fn in the _start_client_internal function.
  • Implement the run_supernode
  • Merge common logic of run_client_app and run_supernode

The load_client_app_fn function now loads the specified ClientApp based on fab_id and fab_version. If fab_id is empty, a default ClientApp (need to be provided by flower-supernode CLI) will be loaded.

@panh99 panh99 changed the base branch from main to mv-run-client-app April 29, 2024 08:57
@panh99 panh99 marked this pull request as ready for review April 29, 2024 09:01
Base automatically changed from mv-run-client-app to main April 29, 2024 16:50
@panh99 panh99 changed the title Implement run_supernode feat(framework) Implement run_supernode May 17, 2024
@danieljanes danieljanes merged commit 8fc4287 into main Jun 13, 2024
29 checks passed
@danieljanes danieljanes deleted the complete-supernode branch June 13, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq