-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicate logs in run_simulation
#3354
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Apr 29, 2024
jafermarq
previously approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is gold!
danieljanes
reviewed
Apr 30, 2024
danieljanes
approved these changes
Apr 30, 2024
mohammadnaseri
pushed a commit
that referenced
this pull request
May 2, 2024
Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
When executing
run_simulation
in Google Colab, duplicate logs appear in the output.Current behaviour:
This behaviour is unintended.
This behaviour is also not observed when running local notebooks in VSCode or JupyterLab.
Related issues/PRs
N/A
Proposal
Explanation
Set
logger.propagate = False
when anasyncio
event is detected. This allows only the child logger to print the message and not the parent logger. See this SO thread.With fix:
Checklist
[ ] Write tests[ ] Update documentationChangelog entry
Any other comments?