Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker) add ServerApp Dockerfile #3390

Merged
merged 4 commits into from
May 6, 2024
Merged

feat(docker) add ServerApp Dockerfile #3390

merged 4 commits into from
May 6, 2024

Conversation

Robert-Steiner
Copy link
Member

Issue

Description

  • Adds Dockerfile for the ServerApp image.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Update the changelog entry below
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Changelog entry

Any other comments?

@Robert-Steiner
feat(docker) add ServerApp Dockerfile
df30481 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner self-assigned this May 2, 2024
@Robert-Steiner Robert-Steiner marked this pull request as ready for review May 2, 2024 15:13
@Robert-Steiner Robert-Steiner requested a review from Moep90 May 2, 2024 15:17
tanertopal
tanertopal approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal enabled auto-merge (squash) May 6, 2024 08:38
@tanertopal tanertopal merged commit 57f99d1 into main May 6, 2024
28 checks passed
@tanertopal tanertopal deleted the feature/serverapp-image branch May 6, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@Moep90 Moep90 Awaiting requested review from Moep90 Moep90 is a code owner

Assignees

@Robert-Steiner Robert-Steiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Robert-Steiner @tanertopal