Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Update CLI auth flags #3503

Merged
merged 22 commits into from
May 24, 2024
Merged

refactor(framework) Update CLI auth flags #3503

merged 22 commits into from
May 24, 2024

Conversation

danielnugraha
Copy link
Contributor

Issue

Description

Having flag that expects multiple arguments is confusing to users.

Related issues/PRs

Proposal

Explanation

Dissolve --require-client-authentication and --authentication-keys into more granular flags that expects one arguments.

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@danieljanes danieljanes enabled auto-merge (squash) May 24, 2024 16:50
@danieljanes danieljanes merged commit 83e9ba4 into main May 24, 2024
29 checks passed
@danieljanes danieljanes deleted the update-cli-flag branch May 24, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@jafermarq jafermarq Awaiting requested review from jafermarq jafermarq is a code owner

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnugraha @danieljanes