feat(framework) Add FlowerTune templates to flwr new
#3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Jun 12, 2024
jafermarq
reviewed
Jun 12, 2024
jafermarq
reviewed
Jun 12, 2024
src/py/flwr/cli/new/templates/app/code/flwrtune/static_config.yaml.tpl
Outdated
Show resolved
Hide resolved
src/py/flwr/cli/new/templates/app/code/flwrtune/config.yaml.tpl
Outdated
Show resolved
Hide resolved
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
reviewed
Jun 13, 2024
There was a problem hiding this comment.
@yan-gao-GY it seems to be working!! I left a couple of small comments. I wonder if there is a better place for the flowertune-specific code added to cli/new/new.py. wdyt @charlesbvll @danieljanes
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
@jafermarq I'm planning a big refactoring of how the templates work/are generated, so I think this is okay if it is not perfect in this PR. |
jafermarq
reviewed
Jun 14, 2024
src/py/flwr/cli/new/templates/app/code/flwrtune/config.yaml.tpl
Outdated
Show resolved
Hide resolved
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
danieljanes
reviewed
Jun 20, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
reviewed
Jun 21, 2024
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
danieljanes
changed the title
flwr new commandflwr new
danieljanes
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
This PR adds flwrtune templates to
flwr newcommand, which allows users to choose one of 4 LLM tasks (including general NLP, finance, medical and code) for its specific FL settings. This will be used for LLM leaderboard later.