Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add ca-certificates package #3591

Merged
merged 2 commits into from
Jul 3, 2024
Merged

feat(framework) Add ca-certificates package #3591

merged 2 commits into from
Jul 3, 2024

Conversation

Robert-Steiner
Copy link
Member

Issue

Description

  • Adds ca-certificates package to update CA certificates.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner
feat(framework:docker) add ca-certificates package
deb3bd0 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner self-assigned this Jun 12, 2024
@Robert-Steiner Robert-Steiner changed the title feat(framework:docker) Add ca-certificates package feat(framework) Add ca-certificates package Jun 12, 2024
@Robert-Steiner Robert-Steiner marked this pull request as ready for review June 13, 2024 08:32
tanertopal
tanertopal approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal enabled auto-merge (squash) July 3, 2024 08:33
@tanertopal tanertopal merged commit 69dd991 into main Jul 3, 2024
29 checks passed
@tanertopal tanertopal deleted the chore/add-ca-certificates-package branch July 3, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moep90 Moep90 Moep90 approved these changes

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees

@Robert-Steiner Robert-Steiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robert-Steiner @tanertopal @Moep90