Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework) Verify message TTL when storing TaskIns and TaskRes #3596

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

mohammadnaseri
Copy link
Contributor

Issue

This PR adds a check to verify TTL when storing a TaskIns or TaskRes. The check is TTL + created_at > current_time and if not it discards it.

panh99
panh99 previously approved these changes Jun 14, 2024
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danieljanes danieljanes merged commit 8fa9c56 into main Sep 26, 2024
32 checks passed
@danieljanes danieljanes deleted the verify-ttl-taskin-taskres-storing branch September 26, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants