feat(framework) Check TTL when retrieving TaskRes #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttl-when-storing-taskres
mohammadnaseri
changed the base branch from
main
to
check-TTL-in-taskins-retrieve
danieljanes
reviewed
Oct 7, 2024
| ) or ( | ||
| node_id is None # Anonymous | ||
| and task_ins.task.consumer.anonymous is True | ||
| and task_ins.task.consumer.node_id == 0 | ||
| and task_ins.task.delivered_at == "" | ||
| and task_ins.task.created_at + task_ins.task.ttl > time.time() |
There was a problem hiding this comment.
Let's do the same thing as we did in the previous PR here
danieljanes
reviewed
Oct 8, 2024
| task_ins = self.task_ins_store.get(reply_to) | ||
| if task_ins is None: | ||
| log(ERROR, "TaskIns with task_id %s does not exist.", reply_to) | ||
| return [] |
There was a problem hiding this comment.
We should not return [] here. Some of the requested task_ids might have responses and we should return those back to the caller. In the future, we need to introduce a way to return errors for those IDs that are either not existing or expired.
danieljanes
reviewed
Oct 8, 2024
|
|
||
| if task_ins.task.created_at + task_ins.task.ttl <= time.time(): | ||
| log(ERROR, "TaskIns with task_id %s is expired.", reply_to) | ||
| return [] |
danieljanes
reviewed
Oct 8, 2024
danieljanes
reviewed
Oct 8, 2024
| task_ins = dict_to_task_ins(row) | ||
| if task_ins.task.created_at + task_ins.task.ttl <= time.time(): | ||
| log(ERROR, "TaskIns with task_id %s is expired.", task_ins.task_id) | ||
| return [] |
panh99
reviewed
Oct 9, 2024
| task_id = state.store_task_ins(task_ins=task_ins) | ||
|
|
||
| task_res = create_task_res( | ||
| producer_node_id=100, |
There was a problem hiding this comment.
Why the consumer_node_id of the TaskIns is 1, but the producer_node_id of the replying TaskRes is 100?
| task_id = state.store_task_ins(task_ins=task_ins) | ||
|
|
||
| task_res = create_task_res( | ||
| producer_node_id=100, |
danieljanes
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR checks if the corresponding
TaskInsexists and remains valid (not expired) when retrievingTaskRes.Please merge after #3620