Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Support non-str config value types #3746

Merged
merged 98 commits into from
Jul 22, 2024
Merged

feat(framework) Support non-str config value types #3746

merged 98 commits into from
Jul 22, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll
feat(framework) Add proto files for override_config with specific type
d0cc112
@charlesbvll
Compile proto files
72eb30a
@charlesbvll
feat(framework) Add overrides to SuperExec with specific type
bd74c73
@charlesbvll
Merge branch 'add-overrides-proto-configrecordvalue' into add-overrid…
be141c3 
…e-config-superexec-configrecordvalue
@charlesbvll
Update serde
8c0d1b9
@charlesbvll
Merge branch 'add-overrides-proto-configrecordvalue' into add-overrid…
519f9f9 
…e-config-superexec-configrecordvalue
@charlesbvll
Add necessary import
0e24f5e
@charlesbvll
feat(framework) Extend ConfigRecordValue serde
3fafa71
@charlesbvll
Fix test
a938ba5
@charlesbvll
Merge branch 'update-serde-to-support-configrecordvalue' into add-ove…
cc01992 
…rride-config-superexec-configrecordvalue
@charlesbvll
Merge branch 'main' into add-overrides-proto-configrecordvalue
9ad4fad
@charlesbvll
feat(framework) Add override_config to Run with specific type
8320c3c
@charlesbvll
Fix file
78fac27
@charlesbvll
Add correct pylint disable
98f2ede
@charlesbvll
Merge branch 'main' into add-overrides-to-run-configrecordvalue
5148329
@charlesbvll
Add override_config
56faf84
@charlesbvll
Merge branch 'update-serde-to-support-configrecordvalue' into add-ove…
d933ba3 
…rrides-to-run-configrecordvalue
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
62b8e15
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
c526d0b
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
5a15a17
@charlesbvll
Fix imports
624f3a3
@charlesbvll
Fix proto test
28b787e
@charlesbvll
Fix test
0274360
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
3d7b61f
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
e5bed16
@charlesbvll
Use serde func
b244389
@charlesbvll
Merge branch 'main' into add-override-config-superexec-configrecordvalue
4dbac7d
@charlesbvll
Merge branch 'add-overrides-proto-configrecordvalue' into change-over…
ec1a62a 
…ride-config-type
@charlesbvll
Merge branch 'update-serde-to-support-configrecordvalue' into change-…
119e957 
…override-config-type
@charlesbvll
Merge branch 'add-overrides-to-run-configrecordvalue' into change-ove…
4a81569 
…rride-config-type
@charlesbvll charlesbvll marked this pull request as ready for review July 22, 2024 09:16
@danieljanes danieljanes changed the title feat(framework) Change override config type feat(framework) Allow more override config types Jul 22, 2024
danieljanes
danieljanes previously approved these changes Jul 22, 2024
View reviewed changes
@danieljanes danieljanes changed the title feat(framework) Allow more override config types feat(framework) Support non-str config value types Jul 22, 2024
@danieljanes danieljanes enabled auto-merge (squash) July 22, 2024 18:24
@danieljanes danieljanes merged commit d24ebe5 into main Jul 22, 2024
34 checks passed
@danieljanes danieljanes deleted the change-override-config-type branch July 22, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlesbvll @danieljanes