Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(examples) Update Flower example using scikit-learn #3777

Merged
merged 28 commits into from
Aug 9, 2024
Merged

refactor(examples) Update Flower example using scikit-learn #3777

merged 28 commits into from
Aug 9, 2024

Conversation

chongshenng
Copy link
Contributor

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@chongshenng chongshenng marked this pull request as ready for review July 25, 2024 20:22
@chongshenng chongshenng marked this pull request as draft July 25, 2024 20:23
@chongshenng chongshenng marked this pull request as ready for review August 8, 2024 15:05
@jafermarq jafermarq changed the title docs(*:skip) Update Flower example using scikit-learn refactor(examples) Update Flower example using scikit-learn Aug 9, 2024
jafermarq
jafermarq reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple of small suggestion. ready to merge otherwise

examples/sklearn-logreg-mnist/README.md Outdated Show resolved Hide resolved
examples/sklearn-logreg-mnist/pyproject.toml Show resolved Hide resolved
examples/sklearn-logreg-mnist/pyproject.toml Outdated Show resolved Hide resolved
examples/sklearn-logreg-mnist/pyproject.toml Outdated Show resolved Hide resolved
examples/sklearn-logreg-mnist/sklearnexample/client_app.py Outdated Show resolved Hide resolved
chongshenng and others added 4 commits August 9, 2024 20:37
@chongshenng @jafermarq
Update examples/sklearn-logreg-mnist/README.md
5cbc1c4 
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
@chongshenng @jafermarq
Update examples/sklearn-logreg-mnist/pyproject.toml
27044c0 
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
@chongshenng @jafermarq
Apply suggestions from code review
810abb4 
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
@jafermarq
Merge branch 'main' into update-sklearn-example
53abb89
@jafermarq jafermarq added the Examples Add or update a Flower example label Aug 9, 2024
@jafermarq
removed unused config_fit callback; reoredered imports; defined `frac…
0877907 
…tion-fit` instead of `min-available-clients`
@jafermarq jafermarq enabled auto-merge (squash) August 9, 2024 20:51
@jafermarq jafermarq merged commit 0334b3d into main Aug 9, 2024
33 checks passed
@jafermarq jafermarq deleted the update-sklearn-example branch August 9, 2024 20:56
chongshenng added a commit that referenced this pull request Aug 11, 2024
@chongshenng @jafermarq
refactor(examples) Update Flower example using scikit-learn (#3777)
f43625b 
Co-authored-by: jafermarq <javier@flower.ai>
chongshenng added a commit that referenced this pull request Aug 13, 2024
@chongshenng @jafermarq
refactor(examples) Update Flower example using scikit-learn (#3777)
df0e931 
Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
Examples Add or update a Flower example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongshenng @jafermarq