Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Update context registration when running an app directory #3815

Merged
merged 7 commits into from
Jul 16, 2024
Merged

feat(framework) Update context registration when running an app directory #3815

merged 7 commits into from
Jul 16, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Jul 16, 2024 •
edited
Loading

When there is not a .fab we still want to be able to read the config in the pyproject.toml and potentially override some values embedded in <Run>.override_config. To do this we need to call get_fused_config_from_dir() when registering a context.

@jafermarq jafermarq changed the title feature(framework) Update context registration process. feature(framework) Update context registration when running from a FAB-like directory Jul 16, 2024
@jafermarq jafermarq changed the title feature(framework) Update context registration when running from a FAB-like directory feature(framework) Update context registration when running a FAB directory instead of a FAB binary Jul 16, 2024
@jafermarq jafermarq changed the title feature(framework) Update context registration when running a FAB directory instead of a FAB binary feature(framework) Update context registration when running a FAB directory Jul 16, 2024
@jafermarq jafermarq marked this pull request as ready for review July 16, 2024 10:14
jafermarq and others added 2 commits July 16, 2024 12:05
@jafermarq @danieljanes
Apply suggestions from code review
122cb31 
Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
@jafermarq
updates
307c29e
@jafermarq jafermarq changed the title feature(framework) Update context registration when running a FAB directory feature(framework) Update context registration when running an app directory Jul 16, 2024
@jafermarq jafermarq changed the title feature(framework) Update context registration when running an app directory feat(framework) Update context registration when running an app directory Jul 16, 2024
@danieljanes danieljanes enabled auto-merge (squash) July 16, 2024 11:42
@danieljanes danieljanes merged commit 1f3fe0f into main Jul 16, 2024
28 checks passed
@danieljanes danieljanes deleted the register-context-using-fab-dir branch July 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes