refactor(examples) Update secure aggregation example #3833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnugraha
changed the title
panh99
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Aug 6, 2024
There was a problem hiding this comment.
@panh99 @danielnugraha most of my comments below are just to align the style of the README.md to those of the examples already migrated (e.g. quickstart-mlx/pytorch/tensorflow/fastai)
examples/flower-secure-aggregation/secaggexample/workflow_with_log.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
…_log.py Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
reviewed
Aug 7, 2024
jafermarq
reviewed
Aug 7, 2024
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
approved these changes
Aug 7, 2024
chongshenng
pushed a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: Heng Pan <pan@flower.ai> Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3858