refactor(examples) Update Flower in 30 minutes example #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnugraha
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
chongshenng
requested changes
Jul 19, 2024
There was a problem hiding this comment.
Thanks for this update @danielnugraha! It's overall fine, the key point to clarify is getting the context to work with node_config, which I haven't get to debug yet right at the end. Otherwise, I only have minor suggestions to how PyTorch transforms are used, which seemed to be faster, and an opportunistic improvement to plotting the histograms.
…example' into update-flwr-30-min-example
jafermarq
reviewed
Jul 22, 2024
jafermarq
approved these changes
Aug 8, 2024
chongshenng
pushed a commit
that referenced
this pull request
Aug 13, 2024
Co-authored-by: jafermarq <javier@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?