docs(framework:skip) Add docs for distributed Docker Compose guide #3928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Robert-Steiner
force-pushed
the
doc/docker-compose-distributed
branch
from
d3d1346
to
d06a914
Compare
Robert-Steiner
force-pushed
the
doc/docker-compose-distributed
branch
2 times, most recently
from
bd7344a
to
75d2082
Compare
chongshenng
requested changes
Sep 16, 2024
There was a problem hiding this comment.
Thanks for the PR @Robert-Steiner! Overall looks good. I've left a few comments in the PR itself.
Nits:
- Can you format and lint the code with
rstfmt? We'll be using this in our CI in the coming days, so it'll be good to get it formatted as well.
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
force-pushed
the
doc/docker-compose-distributed
branch
from
042f8a5
to
06098b7
Compare
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
requested review from
danieljanes and
tanertopal
as code owners
chongshenng
requested changes
Sep 24, 2024
There was a problem hiding this comment.
@Robert-Steiner Tiny suggestions. Can you please reformat once more with rstfmt to enforce the same line lengths throughout? Thanks!
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?