Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(framework:skip) Update PyLint to 3.3.1 #3990

Merged
merged 31 commits into from
Oct 11, 2024
Merged

ci(framework:skip) Update PyLint to 3.3.1 #3990

merged 31 commits into from
Oct 11, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll changed the title ci(framework:skip) Update PyLint and process stubs ci(framework:skip) Update PyLint to 3.2.6 Aug 11, 2024
@charlesbvll charlesbvll marked this pull request as ready for review August 11, 2024 19:37
@charlesbvll charlesbvll changed the title ci(framework:skip) Update PyLint to 3.2.6 ci(framework:skip) Update PyLint to 3.2.7 Sep 13, 2024
panh99
panh99 requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, generally. A few minor comments.

src/py/flwr/server/strategy/bulyan_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/bulyan_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/fedadagrad_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/fedmedian_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/krum_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/strategy/multikrum_test.py Outdated Show resolved Hide resolved
src/py/flwr/server/superlink/fleet/vce/vce_api.py Outdated Show resolved Hide resolved
panh99
panh99 previously approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! @jafermarq Would you mind reviewing the vce_api.py? I am less familiar with this module.

@jafermarq
Copy link
Contributor

Lgtm! @jafermarq Would you mind reviewing the vce_api.py? I am less familiar with this module.

Thanks for the ping! It looks good. Note I made an adjustment to the generate_replies function in driver_client_proxy_test.py to simplify the logic a bit. A response would never be None since the receiving end (the message_handler) will return valid Message carrying an Error if the message type (e.g. "fit", "evaluate", etc) is not understood. @panh99 wdyt?

panh99
panh99 previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chongshenng
chongshenng previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

danieljanes
danieljanes previously approved these changes Oct 10, 2024
View reviewed changes
@danieljanes danieljanes enabled auto-merge (squash) October 10, 2024 19:57
@panh99 panh99 dismissed stale reviews from chongshenng, danieljanes, and themself via 0f632fd October 10, 2024 20:03
@charlesbvll charlesbvll changed the title ci(framework:skip) Update PyLint to 3.2.7 ci(framework:skip) Update PyLint to 3.3.1 Oct 10, 2024
danieljanes
danieljanes previously approved these changes Oct 11, 2024
View reviewed changes
@danieljanes danieljanes merged commit 94ef03e into main Oct 11, 2024
53 checks passed
@danieljanes danieljanes deleted the update-pylint branch October 11, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 panh99 left review comments

@chongshenng chongshenng chongshenng left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@charlesbvll @jafermarq @danieljanes @chongshenng @panh99 @tanertopal