Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework:skip) Update the flwr-clientapp entry point from CLI #4033

Merged
merged 7 commits into from
Aug 17, 2024
Merged

refactor(framework:skip) Update the flwr-clientapp entry point from CLI #4033

merged 7 commits into from
Aug 17, 2024

Conversation

jafermarq
Copy link
Contributor

@jafermarq jafermarq commented Aug 17, 2024 •
edited
Loading

Builds on #4032. Moves CLI entry point to flwr-clientapp (pointing to run_clientapp in supernode.app.py) to an identical function living in client.clientapp.app.py

@jafermarq jafermarq changed the base branch from main to rename-process-to-clientapp August 17, 2024 06:41
@jafermarq jafermarq changed the title refactor(framework) Updated flwr_clientapp CLI entry point refactor(framework) Updated CLI entry point for flwr_clientapp Aug 17, 2024
@jafermarq jafermarq changed the title refactor(framework) Updated CLI entry point for flwr_clientapp refactor(framework) Update CLI entry point for flwr_clientapp Aug 17, 2024
@jafermarq jafermarq changed the title refactor(framework) Update CLI entry point for flwr_clientapp refactor(framework:skip) Update flwr_clientapp CLI entry point Aug 17, 2024
@jafermarq jafermarq changed the title refactor(framework:skip) Update flwr_clientapp CLI entry point refactor(framework:skip) Update flwr-clientapp CLI entry point Aug 17, 2024
@jafermarq jafermarq marked this pull request as ready for review August 17, 2024 07:42
Base automatically changed from rename-process-to-clientapp to main August 17, 2024 08:45
@jafermarq jafermarq changed the title refactor(framework:skip) Update flwr-clientapp CLI entry point refactor(framework:skip) Update the flwr-clientapp entry point from CLI Aug 17, 2024
@danieljanes danieljanes merged commit 4ea34ff into main Aug 17, 2024
34 checks passed
@danieljanes danieljanes deleted the refactor-flwrapp-cli-entry-point branch August 17, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes