Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*:skip) Fix legacy key value format warning in Ubuntu Dockerfile #4090

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

Robert-Steiner
Copy link
Member

Issue

  • Fixes the warning:
1 warning found (use docker --debug to expand):
- LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 35)      

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner self-assigned this Aug 28, 2024
@Robert-Steiner Robert-Steiner changed the title fix(*:skip) Fix Legacy Key Value Format in Ubuntu Dockerfile fix(*:skip) Fix legacy key value format warning in Ubuntu Dockerfile Aug 28, 2024
@Robert-Steiner Robert-Steiner requested a review from Moep90 August 29, 2024 07:21
@Robert-Steiner Robert-Steiner marked this pull request as ready for review August 29, 2024 09:35
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal enabled auto-merge (squash) August 29, 2024 12:17
@tanertopal tanertopal merged commit b817b3b into main Aug 29, 2024
33 checks passed
@tanertopal tanertopal deleted the fix/ubuntu-legacy-warning branch August 29, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants