Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework:skip) Move Docker Hub READMEs to flower repository #4094

Merged
merged 2 commits into from
Aug 29, 2024
Merged

feat(framework:skip) Move Docker Hub READMEs to flower repository #4094

merged 2 commits into from
Aug 29, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Aug 28, 2024 •
edited
Loading

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner
feat(*:skip) Move Docker Hub READMEs to the repository
508f474 
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner self-assigned this Aug 28, 2024
@Robert-Steiner Robert-Steiner requested a review from Moep90 August 29, 2024 07:22
@Robert-Steiner Robert-Steiner marked this pull request as ready for review August 29, 2024 09:38
@Robert-Steiner Robert-Steiner changed the title feat(*:skip) Move Docker Hub READMEs to the repository feat(*:skip) Move Docker Hub READMEs to flower repository Aug 29, 2024
tanertopal
tanertopal approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal enabled auto-merge (squash) August 29, 2024 15:35
@danieljanes danieljanes changed the title feat(*:skip) Move Docker Hub READMEs to flower repository feat(framework:skip) Move Docker Hub READMEs to flower repository Aug 29, 2024
@danieljanes danieljanes disabled auto-merge August 29, 2024 15:37
@danieljanes danieljanes merged commit 01d865e into main Aug 29, 2024
34 checks passed
@danieljanes danieljanes deleted the feat/docker-readme-in-repo branch August 29, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@Moep90 Moep90 Awaiting requested review from Moep90 Moep90 is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

@jafermarq jafermarq Awaiting requested review from jafermarq

Assignees

@Robert-Steiner Robert-Steiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Robert-Steiner @tanertopal @danieljanes