refactor(framework) Update huggingface template for flwr new
#4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongshenng
previously approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Overall looks fine to me. The only minor comment is in pyproject.toml, whether we should set prajjwal1/bert-tiny as default and add a comment for users with access to larger GPUs, e.g.:
model-name = "prajjwal1/bert-tiny" # If you have access to more GPU resources,
# you can try a larger model, such as "distilbert-base-uncased"
chongshenng
reviewed
Sep 11, 2024
chongshenng
reviewed
Sep 11, 2024
chongshenng
previously requested changes
Sep 11, 2024
chongshenng
reviewed
Sep 11, 2024
src/py/flwr/cli/new/templates/app/pyproject.huggingface.toml.tpl
Outdated
Show resolved
Hide resolved
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
danieljanes
approved these changes
Sep 11, 2024
danieljanes
approved these changes
Sep 11, 2024
charlesbvll
pushed a commit
that referenced
this pull request
Sep 11, 2024
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai> Co-authored-by: Daniel J. Beutel <daniel@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
HFflwr newtemplate.needs: #4119