Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(*:skip) Add Python version updater #4208

Merged
merged 12 commits into from
Oct 9, 2024
Merged

ci(*:skip) Add Python version updater #4208

merged 12 commits into from
Oct 9, 2024

Conversation

charlesbvll
Copy link
Member

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@charlesbvll charlesbvll marked this pull request as ready for review September 13, 2024 17:53
Robert-Steiner
Robert-Steiner reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that the script can only be executed by running python dev/update_python.py. Is it possible to call it from within the dev directory as well?

doc/source/conf.py Outdated Show resolved Hide resolved
dev/update_python.py Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) October 9, 2024 14:28
@danieljanes danieljanes merged commit 96e548f into main Oct 9, 2024
50 checks passed
@danieljanes danieljanes deleted the add-python-version-updater branch October 9, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robert-Steiner Robert-Steiner Robert-Steiner approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@charlesbvll @danieljanes @Robert-Steiner