refactor(examples) Update XGBoost comprehensive example #4234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yan-gao-GY
requested review from
jafermarq,
tanertopal and
danieljanes
as code owners
jafermarq
reviewed
Sep 30, 2024
There was a problem hiding this comment.
Hi @yan-gao-GY , this look good. Since this is a comprenhensive example i though it would be good if we show how to save the results to disk. Even having something minimal (a JSON file being updated each round by the strategy) should be sufficient. Maybe following what I did for the update examples/advanced-pytorch?
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
Co-authored-by: Javier <jafermarq@users.noreply.github.com>
jafermarq
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
Update XGBoost comprehensive example to fit new Flower features.