Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add FAB hash to flwr build/install #4304

Merged
merged 30 commits into from
Oct 10, 2024
Merged

feat(framework) Add FAB hash to flwr build/install #4304

merged 30 commits into from
Oct 10, 2024

Conversation

chongshenng
Copy link
Contributor

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@chongshenng chongshenng marked this pull request as ready for review October 8, 2024 10:09
panh99
panh99 reviewed Oct 8, 2024
View reviewed changes
src/py/flwr/cli/install.py Outdated Show resolved Hide resolved
panh99
panh99 reviewed Oct 8, 2024
View reviewed changes
src/py/flwr/common/config.py Outdated Show resolved Hide resolved
panh99
panh99 previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chongshenng chongshenng changed the title feat(framework) Add FAB hash to install feat(framework) Add FAB hash to build and install Oct 9, 2024
@danieljanes danieljanes changed the title feat(framework) Add FAB hash to build and install feat(framework) Add FAB hash to flwr build/install Oct 9, 2024
charlesbvll
charlesbvll reviewed Oct 9, 2024
View reviewed changes
Copy link
Member

@charlesbvll charlesbvll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I added a few minor comments

src/py/flwr/cli/build.py Outdated Show resolved Hide resolved
src/py/flwr/cli/build.py Show resolved Hide resolved
src/py/flwr/cli/run/run.py Outdated Show resolved Hide resolved
src/py/flwr/cli/install.py Outdated Show resolved Hide resolved
src/py/flwr/common/config.py Outdated Show resolved Hide resolved
@danieljanes danieljanes enabled auto-merge (squash) October 10, 2024 12:04
@danieljanes danieljanes merged commit 2b9dbcc into main Oct 10, 2024
58 checks passed
@danieljanes danieljanes deleted the add-fab-hash-install branch October 10, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesbvll charlesbvll charlesbvll approved these changes

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 panh99 left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chongshenng @danieljanes @charlesbvll @panh99