feat(framework) Add PullServerAppInputs and PushServerAppOutputs rpcs to Driver service
#4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafermarq
reviewed
Oct 24, 2024
jafermarq
reviewed
Oct 24, 2024
chongshenng
reviewed
Oct 24, 2024
chongshenng
requested changes
Oct 24, 2024
There was a problem hiding this comment.
Thanks @panh99. I was under the impression we should first mirror the naming as in ClientAppIo, so not using *Process* in the names. Then rename everything later in another PR?
panh99
changed the title
PullServerAppInputs and PushServerAppOutputs rpcs to Driver servicePullServerAppProcessInputs and PushServerAppProcessOutputs rpcs to Driver service
panh99
changed the title
PullServerAppProcessInputs and PushServerAppProcessOutputs rpcs to Driver servicePullServerAppInputs and PushServerAppOutputs rpcs to Driver service
jafermarq
approved these changes
Oct 24, 2024
danieljanes
approved these changes
Oct 24, 2024
chongshenng
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.