Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Generate error TaskRes for invalid cases in LinkState.get_task_res #4369

Merged
merged 36 commits into from
Nov 15, 2024
Merged

feat(framework) Generate error TaskRes for invalid cases in LinkState.get_task_res #4369

merged 36 commits into from
Nov 15, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Oct 24, 2024 •
edited
Loading

For each task_id provided, get_task_res method returns one of the following responses:

  • An error TaskRes if the corresponding TaskIns does not exist or has expired.
  • An error TaskRes if the corresponding TaskRes exists but has expired.
  • The valid TaskRes if the TaskIns has a corresponding valid TaskRes.
  • Nothing if the TaskIns is still valid and waiting for a TaskRes.

@panh99 panh99 marked this pull request as ready for review October 24, 2024 16:56
mohammadnaseri
mohammadnaseri reviewed Oct 25, 2024
View reviewed changes
Copy link
Contributor

@mohammadnaseri mohammadnaseri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM. Some minor comments. Happy to see that those two files are getting more structured.

src/py/flwr/server/superlink/linkstate/in_memory_linkstate.py Show resolved Hide resolved
src/py/flwr/server/superlink/linkstate/utils.py Outdated Show resolved Hide resolved
src/py/flwr/server/superlink/linkstate/utils.py Outdated Show resolved Hide resolved
@panh99 panh99 marked this pull request as draft November 7, 2024 10:38
@panh99 panh99 marked this pull request as ready for review November 15, 2024 13:34
@danieljanes danieljanes merged commit 8ed5b1b into main Nov 15, 2024
55 checks passed
@danieljanes danieljanes deleted the err-reply-get-task-res branch November 15, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohammadnaseri mohammadnaseri mohammadnaseri left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @mohammadnaseri