Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework) Fix the bug in HasField method #4376

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix(framework) Fix the bug in HasField method #4376

merged 3 commits into from
Oct 28, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Oct 25, 2024

For some reason, HasField method doesn't work for scalar fields. We have to get around with this by implementing a _has_field function.

@jafermarq jafermarq mentioned this pull request Oct 25, 2024
Merged
@danieljanes danieljanes enabled auto-merge (squash) October 28, 2024 09:32
@danieljanes danieljanes merged commit 95443d5 into main Oct 28, 2024
53 checks passed
@danieljanes danieljanes deleted the fix-hasfield branch October 28, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panh99 @danieljanes @jafermarq