Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Make now function easier to be patched for unit tests #4385

Merged
merged 2 commits into from
Oct 29, 2024
Merged

refactor(framework) Make now function easier to be patched for unit tests #4385

merged 2 commits into from
Oct 29, 2024

Conversation

panh99
Copy link
Contributor

@panh99 panh99 commented Oct 28, 2024

No description provided.

@panh99 panh99 marked this pull request as ready for review October 28, 2024 16:29
@tanertopal tanertopal enabled auto-merge (squash) October 29, 2024 12:51
tanertopal
tanertopal approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@tanertopal tanertopal merged commit f784de3 into main Oct 29, 2024
53 checks passed
@tanertopal tanertopal deleted the update-now-fn branch October 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panh99 @tanertopal