-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(framework:skip) Update Docker Compose complete
files for 1.13.0
#4413
Conversation
6729530
to
b6e33c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Robert-Steiner Thanks for this. I think the only the Docker image tags needs to be changed to nightly
since it doesn't work with 1.12
right now.
I changed it to nightly, but we’ll need to update it to 1.13.0 before releasing 1.13.0, to make it part of the release tag. I used to change the version after the release, but this caused an issue with the link in the Run Flower Quickstart Examples with Docker Compose doc, where the link points to the correct tag, but the default version is still set to the previous release:
I’ve added a note in the release docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@Robert-Steiner yes, makes sense! |
Signed-off-by: Robert Steiner <robert@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
041982a
to
e352b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Issue
Description
Updates the Docker Compose complete setup to incorporate the upcoming 1.13.0 changes.
Related issues/PRs
Proposal
Explanation
Checklist
#contributions
)Any other comments?