Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(framework:skip) Update Docker Compose complete files for 1.13.0 #4413

Merged
merged 10 commits into from
Nov 11, 2024

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Nov 1, 2024

Issue

Description

Updates the Docker Compose complete setup to incorporate the upcoming 1.13.0 changes.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner self-assigned this Nov 1, 2024
@Robert-Steiner Robert-Steiner force-pushed the feat/update-docker-compose-complete branch from 6729530 to b6e33c0 Compare November 4, 2024 09:23
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Robert-Steiner Thanks for this. I think the only the Docker image tags needs to be changed to nightly since it doesn't work with 1.12 right now.

@Robert-Steiner
Copy link
Member Author

@Robert-Steiner Thanks for this. I think the only the Docker image tags needs to be changed to nightly since it doesn't work with 1.12 right now.

I changed it to nightly, but we’ll need to update it to 1.13.0 before releasing 1.13.0, to make it part of the release tag. I used to change the version after the release, but this caused an issue with the link in the Run Flower Quickstart Examples with Docker Compose doc, where the link points to the correct tag, but the default version is still set to the previous release:

curl https://raw.githubusercontent.com/adap/flower/refs/tags/v1.12.0/src/docker/complete/compose.yml \
    -o compose.yml

I’ve added a note in the release docs.

chongshenng
chongshenng previously approved these changes Nov 5, 2024
Copy link
Contributor

@chongshenng chongshenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chongshenng
Copy link
Contributor

I changed it to nightly, but we’ll need to update it to 1.13.0 before releasing 1.13.0, to make it part of the release tag

@Robert-Steiner yes, makes sense!

Robert-Steiner and others added 3 commits November 6, 2024 11:34
Signed-off-by: Robert Steiner <robert@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
@Robert-Steiner Robert-Steiner marked this pull request as ready for review November 6, 2024 17:58
@tanertopal tanertopal enabled auto-merge (squash) November 11, 2024 11:45
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit cb673d6 into main Nov 11, 2024
55 checks passed
@tanertopal tanertopal deleted the feat/update-docker-compose-complete branch November 11, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants