Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Make federation_options in Exec API use ConfigsRecords #4453

Merged
merged 8 commits into from
Nov 7, 2024
Merged

refactor(framework) Make federation_options in Exec API use ConfigsRecords #4453

merged 8 commits into from
Nov 7, 2024

Conversation

jafermarq
Copy link
Contributor

This PR replaces the federation_config with federation_options. The change brings also uses a ConfigsRecord.

@jafermarq jafermarq requested a review from panh99 November 7, 2024 13:57
@jafermarq jafermarq marked this pull request as ready for review November 7, 2024 14:23
This was referenced Nov 7, 2024
Closed
Merged
@danieljanes danieljanes enabled auto-merge (squash) November 7, 2024 19:13
@danieljanes danieljanes merged commit d83edbb into main Nov 7, 2024
52 of 53 checks passed
@danieljanes danieljanes deleted the replace-fed-settings-with-options branch November 7, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 Awaiting requested review from panh99

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jafermarq @danieljanes