docs(framework:skip) Update Docker docs for 1.13.0 #4470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chongshenng
reviewed
Nov 11, 2024
chongshenng
reviewed
Nov 11, 2024
chongshenng
reviewed
Nov 11, 2024
chongshenng
requested changes
Nov 11, 2024
There was a problem hiding this comment.
Thanks @Robert-Steiner! Only small edits, but otherwise lgtm!
Robert-Steiner
force-pushed
the
doc/update-docker-1.13.0
branch
from
f94579e to
60aa4ed
Compare
Signed-off-by: Robert Steiner <robert@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
Robert-Steiner
force-pushed
the
doc/update-docker-1.13.0
branch
from
60aa4ed to
58a8380
Compare
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
reviewed
Nov 18, 2024
chongshenng
requested changes
Nov 18, 2024
There was a problem hiding this comment.
@Robert-Steiner Thanks for the extensive update! The updates look generally good, just some corrections to terminology.
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Signed-off-by: Robert Steiner <robert@flower.ai>
|
@chongshenng, thanks for the careful review. I somehow mixed up the |
chongshenng
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for your patience @Robert-Steiner. Main comments come from the recent changes to flwr-serverapp and flwr-clientapp CLI arguments.
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
chongshenng
approved these changes
Nov 19, 2024
Robert-Steiner
requested review from
tanertopal and
danieljanes
as code owners
danieljanes
approved these changes
Nov 20, 2024
flydump
pushed a commit
to flydump/flower
that referenced
this pull request
Dec 8, 2024
Signed-off-by: Robert Steiner <robert@flower.ai> Co-authored-by: Chong Shen Ng <chong.shen@flower.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Updates Docker docs for 1.13.0.
Related issues/PRs
Proposal
Explanation
Checklist
#contributions)Any other comments?