Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework:skip) Set default client and server gRPC addresses #4491

Merged
merged 24 commits into from
Nov 15, 2024
Merged

refactor(framework:skip) Set default client and server gRPC addresses #4491

merged 24 commits into from
Nov 15, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Nov 14, 2024 •
edited
Loading

@chongshenng chongshenng marked this pull request as ready for review November 14, 2024 08:10
@chongshenng chongshenng changed the title feaet(framework:skip) Add ServerAppIo client gRPC address feat(framework:skip) Add ServerAppIo client gRPC address Nov 14, 2024
@chongshenng chongshenng changed the title feat(framework:skip) Add ServerAppIo client gRPC address refactor(framework:skip) Change default gRPC address constants from 0.0.0.0 to 127.0.0.1 Nov 14, 2024
@chongshenng chongshenng changed the title refactor(framework:skip) Change default gRPC address constants from 0.0.0.0 to 127.0.0.1 refactor(framework:skip) Set default client and server gRPC addresses Nov 14, 2024
@chongshenng chongshenng mentioned this pull request Nov 14, 2024
Merged
chongshenng added a commit that referenced this pull request Nov 14, 2024
@chongshenng
Merge #4491
8b15763
panh99
panh99 reviewed Nov 14, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! Amazing job.

src/py/flwr/common/constant.py Outdated Show resolved Hide resolved
src/py/flwr/common/constant.py Outdated Show resolved Hide resolved
src/py/flwr/server/app.py Outdated Show resolved Hide resolved
src/py/flwr/server/run_serverapp.py Show resolved Hide resolved
src/py/flwr/server/run_serverapp.py Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/superexec/deployment.py Outdated Show resolved Hide resolved
src/py/flwr/superexec/deployment.py Outdated Show resolved Hide resolved
panh99
panh99 previously approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes merged commit 637a2cb into main Nov 15, 2024
55 checks passed
@danieljanes danieljanes deleted the add-serverappio-client-address branch November 15, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@panh99 panh99 panh99 left review comments

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chongshenng @danieljanes @panh99