Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(framework:skip) Ignore deleted Docker READMEs #4564

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

Robert-Steiner
Copy link
Member

Issue

Description

  • The job GitHub Actions Run failed because the filter also included deleted files. I updated the filter to include only added or modified README files.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@Robert-Steiner Robert-Steiner changed the title fix(framework:skip) Ingore deleted Docker READMEs fix(framework:skip) Ingnore deleted Docker READMEs Nov 21, 2024
@Robert-Steiner Robert-Steiner changed the title fix(framework:skip) Ingnore deleted Docker READMEs fix(framework:skip) Ignore deleted Docker READMEs Nov 21, 2024
Signed-off-by: Robert Steiner <robert@flower.ai>
@danieljanes danieljanes enabled auto-merge (squash) November 21, 2024 20:07
@danieljanes danieljanes merged commit df1faa3 into main Nov 21, 2024
55 checks passed
@danieljanes danieljanes deleted the fix/docker-readme-ci branch November 21, 2024 20:15
flydump pushed a commit to flydump/flower that referenced this pull request Dec 8, 2024
Signed-off-by: Robert Steiner <robert@flower.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants