Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework) Make flwr-simulation connect without TLS as default #4568

Open
wants to merge 3 commits into
base: fix-simulation-exec
Choose a base branch
from
Open

fix(framework) Make flwr-simulation connect without TLS as default #4568

wants to merge 3 commits into from
+11 −5

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Nov 22, 2024 •
edited
Loading

@chongshenng
break(framework) Remove secure connection from �[92mINFO �[0m: Starti…
7bc8620 
…ng Flower Simulation

�[91mERROR �[0m:     `flwr-simulation` does not support TLS yet. Please use the '--insecure' flag.
@chongshenng
Merge fix
9256eb2
@chongshenng
Add root-certificates
0a50eec
@chongshenng chongshenng changed the title break(framework) Remove --root-certificates for flwr-simulation break(framework) Make flwr-simulation connect without TLS as default Nov 22, 2024
@chongshenng chongshenng changed the title break(framework) Make flwr-simulation connect without TLS as default fix(framework) Make flwr-simulation connect without TLS as default Nov 22, 2024
@chongshenng chongshenng changed the base branch from fix-simulation-exec to main November 22, 2024 08:54
@chongshenng chongshenng changed the base branch from main to fix-simulation-exec November 22, 2024 08:54
@chongshenng chongshenng changed the base branch from fix-simulation-exec to main November 22, 2024 08:55
@chongshenng chongshenng changed the base branch from main to fix-simulation-exec November 22, 2024 08:55
@chongshenng chongshenng mentioned this pull request Nov 22, 2024
Open
@chongshenng chongshenng marked this pull request as ready for review November 24, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chongshenng