Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Introduce try-except block to flwr run #4621

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat(framework) Introduce try-except block to flwr run #4621

merged 8 commits into from
Dec 4, 2024

Conversation

chongshenng
Copy link
Contributor

Needed to catch exceptions and return a JSON-formatted error message.

Merge after

@chongshenng chongshenng changed the base branch from main to update-exec-proto December 3, 2024 10:56
@chongshenng chongshenng marked this pull request as ready for review December 3, 2024 10:56
@chongshenng chongshenng changed the base branch from update-exec-proto to main December 3, 2024 10:58
@chongshenng chongshenng changed the base branch from main to update-exec-proto December 3, 2024 11:00
This was referenced Dec 3, 2024
Merged
Merged
@chongshenng chongshenng changed the base branch from update-exec-proto to main December 3, 2024 14:03
@chongshenng chongshenng changed the base branch from main to update-exec-proto December 3, 2024 14:04
Base automatically changed from update-exec-proto to main December 4, 2024 11:25
@danieljanes danieljanes enabled auto-merge (squash) December 4, 2024 11:44
@danieljanes danieljanes merged commit e0e5452 into main Dec 4, 2024
55 checks passed
@danieljanes danieljanes deleted the add-try-except-flwr-run branch December 4, 2024 11:52
flydump pushed a commit to flydump/flower that referenced this pull request Dec 8, 2024
@chongshenng @flydump
feat(framework) Introduce try-except block to flwr run (adap#4621)
eb747c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq left review comments

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chongshenng @danieljanes @jafermarq