Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Update ServerAppIoServicer RPCs for flwr stop #4629

Merged
merged 16 commits into from
Dec 11, 2024
Merged

feat(framework) Update ServerAppIoServicer RPCs for flwr stop #4629

merged 16 commits into from
Dec 11, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Dec 4, 2024 •
edited
Loading

  • Add GetRunStatus RPC to ServerAppIoServicer
  • Add run_id to PushTaskInsRequest and PullTaskResRequest.

Merge before:

@chongshenng chongshenng marked this pull request as ready for review December 4, 2024 08:52
@chongshenng chongshenng marked this pull request as draft December 4, 2024 08:55
@chongshenng chongshenng marked this pull request as ready for review December 4, 2024 08:59
panh99
panh99 reviewed Dec 4, 2024
View reviewed changes
src/proto/flwr/proto/control.proto Outdated Show resolved Hide resolved
src/proto/flwr/proto/exec.proto Outdated Show resolved Hide resolved
@chongshenng chongshenng changed the title feat(framework) Add protos for flwr stop feat(framework) Update protos for flwr stop Dec 9, 2024
@chongshenng chongshenng mentioned this pull request Dec 9, 2024
Closed
@chongshenng chongshenng changed the title feat(framework) Update protos for flwr stop feat(framework) Update ServerAppIoServicer RPCs for flwr stop Dec 9, 2024
@chongshenng chongshenng mentioned this pull request Dec 9, 2024
Merged
@danieljanes danieljanes enabled auto-merge (squash) December 11, 2024 15:38
@danieljanes danieljanes merged commit 9a05a34 into main Dec 11, 2024
55 checks passed
@danieljanes danieljanes deleted the add-flwr-stop-protos branch December 11, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panh99 panh99 panh99 left review comments

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chongshenng @danieljanes @jafermarq @panh99