Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(framework) Add exception handling to SuperNode for graceful exit when stopped #4668

Merged
merged 108 commits into from
Dec 16, 2024
Merged

feat(framework) Add exception handling to SuperNode for graceful exit when stopped #4668

merged 108 commits into from
Dec 16, 2024

Conversation

chongshenng
Copy link
Contributor

@chongshenng chongshenng commented Dec 10, 2024 •
edited
Loading

@chongshenng
Add protos for flwr stop
3a2ef95
@chongshenng
Add StopRun to ExecServicer
3019ebb
@chongshenng
Merge branch 'main' into add-flwr-stop-protos
dc7c8e6
@chongshenng
Merge main
a15fb4b
@chongshenng
Update
dde8471
@chongshenng
feat(framework) Add flwr stop CLI
a46c6b4
@chongshenng
Add noqa
2f3be4f
@chongshenng
Init
cd1a6bc
@chongshenng
Initial add
48501f0
@chongshenng
Remove FleetServicer context abort
78084ba
@chongshenng
Merge main
483c8f1
@chongshenng
Remove FleetServicer check
fc84267
@chongshenng
Update
6aa749d
@chongshenng
Update pylint ignores
0e3f577
@chongshenng
Merge main
3217740
@chongshenng
Update protos
18d10db
@chongshenng
Add GetRunStatus
2ebd50e
@chongshenng
Add run_id to PushTaskInsRequest and PullTaskResRequest
468ac5e
@chongshenng
Update
27e7088
@chongshenng
Reduce diff
9c0a40f
@chongshenng
Fix GetRunStatus
73483b8
@chongshenng
Merge branch 'add-flwr-stop-protos' into add-context-abort
6b5b469
@chongshenng
Update
f91ede3
@chongshenng
Add set
4f33992
@chongshenng
Remove RunStatus check
0a474a1
@chongshenng
Merge branch 'add-flwr-stop-protos' into add-context-abort
1ca2035
@chongshenng
Merge branch 'main' into add-flwr-stop-protos
754293d
@chongshenng
Merge branch 'add-flwr-stop-protos' into add-context-abort
fd13678
@chongshenng
Merge branch 'main' into add-flwr-stop-protos
3ff5ec8
@chongshenng
Merge branch 'add-flwr-stop-protos' into add-context-abort
e01debf
@chongshenng chongshenng changed the base branch from delete-stopped-run-linkstate-msgs to main December 12, 2024 21:21
@chongshenng chongshenng changed the base branch from main to delete-stopped-run-linkstate-msgs December 12, 2024 21:24
@chongshenng chongshenng changed the base branch from delete-stopped-run-linkstate-msgs to main December 12, 2024 22:49
@chongshenng chongshenng changed the base branch from main to delete-stopped-run-linkstate-msgs December 12, 2024 22:56
@chongshenng chongshenng changed the title feat(framework) Add abort to FleetServicer feat(framework) Add exception handling to SuperNode for graceful exit when stopped Dec 12, 2024
Base automatically changed from delete-stopped-run-linkstate-msgs to main December 13, 2024 17:47
@chongshenng chongshenng marked this pull request as ready for review December 14, 2024 20:07
panh99
panh99 reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall! Just one minor comment.

src/py/flwr/client/app.py Outdated Show resolved Hide resolved
src/py/flwr/client/app.py Outdated Show resolved Hide resolved
panh99
panh99 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@panh99 panh99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danieljanes danieljanes enabled auto-merge (squash) December 16, 2024 11:41
@danieljanes danieljanes merged commit 830b795 into main Dec 16, 2024
55 checks passed
@danieljanes danieljanes deleted the add-fleet-abort branch December 16, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panh99 panh99 panh99 approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chongshenng @danieljanes @panh99