Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework) Correct tutorial URLs in the README #4671

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix(framework) Correct tutorial URLs in the README #4671

merged 3 commits into from
Dec 11, 2024

Conversation

yanmxa
Copy link
Contributor

@yanmxa yanmxa commented Dec 11, 2024 •
edited
Loading

Issue

Description

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@yanmxa
correct tutorial url
f5ee06a 
Signed-off-by: myan <myan@redhat.com>
@yanmxa yanmxa changed the title Correct tutorial URLs in the README fix(framework) Correct tutorial URLs in the README Dec 11, 2024
jafermarq
jafermarq reviewed Dec 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
jafermarq
jafermarq approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @yanmxa !! I build on top of your changes and also updated the URL for the google Colab links

@jafermarq jafermarq changed the title fix(framework) Correct tutorial URLs in the README fix(docs) Correct tutorial URLs in the README Dec 11, 2024
@jafermarq jafermarq changed the title fix(docs) Correct tutorial URLs in the README fix(framework) Correct tutorial URLs in the README Dec 11, 2024
tanertopal
tanertopal approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit d67c38f into adap:main Dec 11, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@tanertopal tanertopal tanertopal approved these changes

@danieljanes danieljanes Awaiting requested review from danieljanes danieljanes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yanmxa @tanertopal @jafermarq