Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(framework) Add request validation to ServerAppIoServicer #4720

Merged
merged 4 commits into from
Dec 17, 2024
Merged

refactor(framework) Add request validation to ServerAppIoServicer #4720

merged 4 commits into from
Dec 17, 2024

Conversation

chongshenng
Copy link
Contributor

  • Add validation to PushTaskInsRequest: all sent TaskIns must have the same run_id
  • Add validation to PullTaskResRequest: all requested TaskRes must belong to the provided run_id

@chongshenng chongshenng marked this pull request as ready for review December 16, 2024 16:03
@danieljanes danieljanes enabled auto-merge (squash) December 17, 2024 15:15
@danieljanes danieljanes merged commit 7f3acaf into main Dec 17, 2024
55 checks passed
@danieljanes danieljanes deleted the add-serverappio-servicer-req-validation branch December 17, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafermarq jafermarq jafermarq approved these changes

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chongshenng @danieljanes @jafermarq