Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples) Remove numpy specification in vertical-fl #4724

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

TheVidz
Copy link
Contributor

@TheVidz TheVidz commented Dec 16, 2024

… dependency conflict

Issue

This PR is to fix issue #4722

Description

Removes the numpy specification in pyproject.toml. As this was causing a dependency conflict. This issue arises because until recently flower had to use numpy<2.0 but this was removed a couple of releases ago.

Related issues/PRs

Proposal

Explanation

Checklist

  • Implement proposed change
  • Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)

Any other comments?

@jafermarq jafermarq changed the title fix(example) Removing numpy specification in vertical-fl to solve conflict fix(examples) Remove numpy specification in vertical-fl Dec 16, 2024
Copy link
Contributor

@jafermarq jafermarq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @TheVidz !!

@jafermarq jafermarq enabled auto-merge (squash) December 16, 2024 19:45
@jafermarq jafermarq merged commit 0d1cff5 into adap:main Dec 16, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants