Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(framework) Fix UnboundLocalError for hashed run ID in flwr-serverapp #4752

Merged
merged 2 commits into from
Dec 20, 2024
Merged

fix(framework) Fix UnboundLocalError for hashed run ID in flwr-serverapp #4752

merged 2 commits into from
Dec 20, 2024

Conversation

chongshenng
Copy link
Contributor

hash_run_id is not set and will throw the error:

UnboundLocalError: cannot access local variable 'hash_run_id' where it is not associated with a value

This fix sets hash_run_id to None outside the while loop.

@chongshenng chongshenng changed the title fix(framework) Fix UnboundLocalError for hashed run ID in flwr-serverapp fix(framework) Fix UnboundLocalError for hashed run ID in flwr-serverapp Dec 20, 2024
@chongshenng chongshenng marked this pull request as ready for review December 20, 2024 10:34
@danieljanes danieljanes enabled auto-merge (squash) December 20, 2024 10:58
chongshenng added a commit that referenced this pull request Dec 20, 2024
@chongshenng
Add #4752 to changelog. Fix minor typos
7a3bf32
@danieljanes danieljanes merged commit fddcd17 into main Dec 20, 2024
55 checks passed
@danieljanes danieljanes deleted the fix-serverapp-event branch December 20, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieljanes danieljanes danieljanes approved these changes

@tanertopal tanertopal Awaiting requested review from tanertopal tanertopal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chongshenng @danieljanes