Final cleanups

adapter-hub · Jan 6, 2022 · 2f9e3f9 · 2f9e3f9
1 parent d7345ef
commit 2f9e3f9
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 15 deletions.
diff --git a/src/transformers/models/bart/modeling_bart.py b/src/transformers/models/bart/modeling_bart.py
@@ -25,7 +25,6 @@
 from torch.nn import CrossEntropyLoss, MSELoss
 
 from ...activations import ACT2FN
-from ...adapters.context import AdapterSetup
 from ...adapters.model_mixin import InvertibleAdaptersMixin, ModelWithHeadsAdaptersMixin
 from ...adapters.models.bart import (
     BartDecoderLayerAdaptersMixin,

diff --git a/src/transformers/models/distilbert/modeling_distilbert.py b/src/transformers/models/distilbert/modeling_distilbert.py
@@ -27,7 +27,6 @@
 from torch.nn import BCEWithLogitsLoss, CrossEntropyLoss, MSELoss
 
 from ...activations import gelu
-from ...adapters.context import AdapterSetup
 from ...adapters.model_mixin import ModelWithHeadsAdaptersMixin
 from ...adapters.models.distilbert import (
     DistilBertModelAdaptersMixin,

diff --git a/src/transformers/models/gpt2/modeling_gpt2.py b/src/transformers/models/gpt2/modeling_gpt2.py
@@ -34,7 +34,6 @@
     is_amp_available = False
 
 from ...activations import ACT2FN
-from ...adapters.context import AdapterSetup
 from ...adapters.model_mixin import ModelWithHeadsAdaptersMixin
 from ...adapters.models.gpt2 import GPT2DecoderBlockAdaptersMixin, GPT2ModelAdapterMixin, GPT2ModelHeadsMixin
 from ...file_utils import (

diff --git a/src/transformers/models/mbart/modeling_mbart.py b/src/transformers/models/mbart/modeling_mbart.py
@@ -24,7 +24,6 @@
 from torch.nn import CrossEntropyLoss, MSELoss
 
 from ...activations import ACT2FN
-from ...adapters.context import AdapterSetup
 from ...adapters.model_mixin import InvertibleAdaptersMixin, ModelWithHeadsAdaptersMixin
 from ...adapters.models.bart import (
     BartDecoderLayerAdaptersMixin,

diff --git a/src/transformers/models/t5/modeling_t5.py b/src/transformers/models/t5/modeling_t5.py
@@ -26,7 +26,6 @@
 from torch.utils.checkpoint import checkpoint
 
 from ...activations import ACT2FN
-from ...adapters.context import AdapterSetup
 from ...adapters.model_mixin import InvertibleAdaptersMixin, ModelWithHeadsAdaptersMixin
 from ...adapters.models.t5 import (
     T5BlockAdaptersMixin,

diff --git a/utils/check_adapters.py b/utils/check_adapters.py
@@ -1,8 +1,6 @@
-import inspect
-
 import transformers
 from check_repo import get_models
-from transformers import ModelAdaptersMixin, ModelWithFlexibleHeadsAdaptersMixin
+from transformers import ModelAdaptersMixin
 
 
 MODELS_WITH_ADAPTERS = [
@@ -41,13 +39,6 @@ def check_models_implement_mixin():
                             and model_name not in IGNORE_NOT_IMPLEMENTING_MIXIN
                         ):
                             failures.append(f"{model_name} should implement ModelAdaptersMixin.")
-                        forward_fn_params = inspect.signature(model_class.forward).parameters
-                        # all classes implementing ModelWithFlexibleHeadsAdaptersMixin should additionally provide adapter_names as parameter
-                        if (
-                            issubclass(model_class, ModelWithFlexibleHeadsAdaptersMixin)
-                            and "adapter_names" not in forward_fn_params
-                        ):
-                            failures.append(f"{model_name}'s forward() method should provide adapter_names parameter.")
     if len(failures) > 0:
         raise Exception(f"There were {len(failures)} failures:\n" + "\n".join(failures))