Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adapter support to seq2seq example scripts (translation & summarization) #141

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

calpt
Copy link
Member

@calpt calpt commented Apr 6, 2021

Implementation tested with adapter-hub/Hub#24.

This PR also patches the new check_min_version() introduced by HF in all example scripts so that it doesn't use our version but the underlying HF version.

@calpt calpt marked this pull request as ready for review April 6, 2021 15:55
@calpt calpt requested a review from hSterz April 6, 2021 15:56
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@calpt calpt merged commit 682d5e7 into adapter-hub:v2 Apr 7, 2021
@calpt calpt deleted the seq2seq-training branch April 7, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants