Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add adapter_names argument #176

Merged
merged 4 commits into from
May 26, 2021
Merged

Re-add adapter_names argument #176

merged 4 commits into from
May 26, 2021

Conversation

calpt
Copy link
Member

@calpt calpt commented May 19, 2021 •
edited
Loading

Fixes #165.
Re-adds the adapter_names argument to all *ModelWithHeads & *Model classes with adapter support.

@calpt calpt requested a review from hSterz May 20, 2021 14:49
@calpt calpt marked this pull request as ready for review May 20, 2021 14:49
@calpt calpt merged commit 6c81d2f into adapter-hub:master May 26, 2021
@calpt calpt deleted the dev/adapters_param branch May 26, 2021 14:41
@calpt calpt mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapter models no longer work effectively in multi-threaded contexts
2 participants
@calpt @hSterz