Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchSplit #177

Merged
merged 49 commits into from
Jul 6, 2021
Merged

BatchSplit #177

merged 49 commits into from
Jul 6, 2021

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented May 19, 2021

Add new composition block BatchSplit

@hSterz hSterz marked this pull request as ready for review May 24, 2021 10:28
@hSterz hSterz requested a review from calpt May 24, 2021 10:29
@hSterz hSterz marked this pull request as draft May 28, 2021 09:35
@hSterz hSterz marked this pull request as ready for review June 3, 2021 09:36
@calpt calpt changed the base branch from master to develop June 11, 2021 13:16
@hSterz hSterz marked this pull request as draft June 24, 2021 11:00
@hSterz hSterz marked this pull request as ready for review June 30, 2021 11:33
@hSterz hSterz requested a review from calpt June 30, 2021 11:33
calpt
calpt reviewed Jul 1, 2021
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Could you also undo the file moves in the examples? Probably got messed up with a merge

src/transformers/adapters/layer.py Outdated Show resolved Hide resolved
src/transformers/adapters/heads.py Show resolved Hide resolved
src/transformers/adapters/heads.py Outdated Show resolved Hide resolved
src/transformers/adapters/heads.py Show resolved Hide resolved
tests/test_adapter_heads.py Show resolved Hide resolved
@hSterz hSterz requested a review from calpt July 2, 2021 13:25
calpt
calpt approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! 🚀

src/transformers/adapters/heads.py Outdated Show resolved Hide resolved
src/transformers/adapters/heads.py Show resolved Hide resolved
src/transformers/adapters/heads.py Show resolved Hide resolved
@hSterz hSterz merged commit e80704a into adapter-hub:develop Jul 6, 2021
@hSterz hSterz deleted the dev/batch_split branch September 29, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calpt calpt calpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hSterz @calpt