Add delete_adapter(), delete_adapter_fusion() and delete_head() methods #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hSterz
reviewed
Jun 25, 2021
hSterz
reviewed
Jun 25, 2021
| del self.heads[head_name] | ||
| if self.active_head == head_name: | ||
| self.active_head = None | ||
|
|
There was a problem hiding this comment.
When deleting a head that is the active head, the active head is set to None but when deleting an adapter in the active adapters setup the setup remains as it is. Maybe it would be better to handle these two cases similarily
hSterz
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_adapter()), AdapterFusion (delete_adapter_fusion()) and prediction heads (delete_head())overwrite_oktoadd_adapter()to overwrite an existing adapter with the same name.Resolves #179.