Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate AdapterTrainer Class #218

Merged
merged 32 commits into from
Sep 16, 2021
Merged

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented Aug 10, 2021

Implement adapter training in a separate class, for better maintenance

@hSterz hSterz marked this pull request as draft August 10, 2021 16:44
@hSterz hSterz changed the base branch from master to develop August 22, 2021 09:02
@hSterz hSterz changed the base branch from develop to master August 24, 2021 09:13
@hSterz hSterz marked this pull request as ready for review August 26, 2021 09:51
@hSterz hSterz requested a review from calpt September 6, 2021 12:34
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Just one question: do we have a test for load_best_model_at_end with adapters?

@hSterz hSterz merged commit fb98f06 into adapter-hub:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants