Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel training #226

Merged
merged 14 commits into from
Sep 14, 2021
Merged

Parallel training #226

merged 14 commits into from
Sep 14, 2021

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented Aug 31, 2021

Added test for parallel training and MultiHeadOutput to use Parallel and BatchSplit with the Trainer

@hSterz hSterz linked an issue Aug 31, 2021 that may be closed by this pull request
"Parallel" option for training? Parallel adapter outputs required (without interacting with each other). #223
Closed
@hSterz hSterz requested a review from calpt September 1, 2021 10:21
calpt
calpt reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, some of which we already discussed :)

src/transformers/adapters/hub_mixin.py Outdated Show resolved Hide resolved
tests/test_adapter_composition.py Show resolved Hide resolved
tests/test_adapter_heads.py Outdated Show resolved Hide resolved
@hSterz hSterz requested a review from calpt September 6, 2021 09:21
calpt
calpt approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hSterz hSterz merged commit e396d9c into adapter-hub:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calpt calpt calpt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Parallel" option for training? Parallel adapter outputs required (without interacting with each other).
2 participants
@hSterz @calpt