Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify built-in & custom head implementation #252

Merged
merged 13 commits into from
Feb 8, 2022

Conversation

hSterz
Copy link
Member

@hSterz hSterz commented Nov 24, 2021

Change adding custom heads to make it more similar to the other heads and more intuitive

@calpt calpt changed the title Dev/more intuittive heads Dev/more intuitive heads Dec 8, 2021
@hSterz hSterz marked this pull request as ready for review December 17, 2021 13:10
@hSterz hSterz requested a review from calpt December 17, 2021 13:10
Copy link
Member

@calpt calpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

tests/test_adapter_custom_head.py Outdated Show resolved Hide resolved
@calpt calpt changed the title Dev/more intuitive heads Unify built-in & custom head implementation Dec 17, 2021
Co-authored-by: calpt <calpt@mail.de>
@calpt calpt force-pushed the master branch 2 times, most recently from 6245d31 to d9c06ec Compare January 6, 2022 19:43
@calpt calpt force-pushed the master branch 3 times, most recently from 0399280 to 675d10e Compare January 31, 2022 22:27
@hSterz hSterz changed the base branch from master to develop February 8, 2022 09:01
@hSterz hSterz merged commit d968d0f into adapter-hub:develop Feb 8, 2022
calpt pushed a commit that referenced this pull request Feb 8, 2022
Unify built-in & custom head implementation such that except for the head_type specification when adding a custom head they are the same.
Co-authored-by: calpt <calpt@mail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants