-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify built-in & custom head implementation #252
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calpt
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
calpt
changed the title
Dev/more intuitive heads
Unify built-in & custom head implementation
Dec 17, 2021
Co-authored-by: calpt <calpt@mail.de>
calpt
force-pushed
the
master
branch
2 times, most recently
from
January 6, 2022 19:43
6245d31
to
d9c06ec
Compare
calpt
force-pushed
the
master
branch
3 times, most recently
from
January 31, 2022 22:27
0399280
to
675d10e
Compare
calpt
pushed a commit
that referenced
this pull request
Feb 8, 2022
Unify built-in & custom head implementation such that except for the head_type specification when adding a custom head they are the same. Co-authored-by: calpt <calpt@mail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change adding custom heads to make it more similar to the other heads and more intuitive