Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation and consistency issues for AdapterFusion methods #259

Merged
merged 7 commits into from
Dec 21, 2021
Merged

Fix documentation and consistency issues for AdapterFusion methods #259

merged 7 commits into from
Dec 21, 2021

Conversation

calpt
Copy link
Member

@calpt calpt commented Dec 8, 2021

Follow-up to #250.

@calpt calpt marked this pull request as ready for review December 16, 2021 09:43
@calpt calpt requested a review from hSterz December 16, 2021 09:43
hSterz
hSterz approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@hSterz hSterz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/transformers/adapters/model_mixin.py Outdated Show resolved Hide resolved
@calpt calpt merged commit 68ebde3 into adapter-hub:master Dec 21, 2021
@calpt calpt deleted the fix/adapter_fusion_doc branch December 21, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hSterz hSterz hSterz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calpt @hSterz