Add ForwardContext to wrap model forward pass
#267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calpt
force-pushed
the
dev/forward_context
branch
from
8462511
to
f6cb2ef
Compare
calpt
force-pushed
the
dev/forward_context
branch
from
aab5a10
to
1d39ec4
Compare
calpt
force-pushed
the
dev/forward_context
branch
from
09d5707
to
ae92427
Compare
hSterz
approved these changes
Jan 28, 2022
|
This PR/issue depends on: Automatically provided by Dependent Issues (🤖). |
calpt
force-pushed
the
dev/forward_context
branch
from
ae92427
to
ffc8519
Compare
calpt
force-pushed
the
dev/forward_context
branch
from
6ed088f
to
a5c36d2
Compare
calpt
added a commit
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #257, depends on #263
This PR adds a new
ForwardContextclass which provides a thread-local context to the forward pass of a model. This context can be used to store information relevant to the current forward pass without the need to add new parameters to the method definitions.The context should be added to all adapter-supporting models by decorating the respective base model
forward()methods with@ForwardContext.wrap.This functionality is mainly for future use. Currently, it only replaces the
pre_transformer_forward()method.